-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(command-dev): support frameworks without a port #4020
Conversation
📊 Benchmark resultsComparing with cbf029f Package size: 356 MB(no change)
Legend
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome this should now support the remix use case! :)
Thx for adding a test ;)
@lukasholzer I had to fix one of our tests utilities in 6de6b32 to get Windows tests to pass. The problem is that on Windows the CLI will print that the server is ready before exiting with an error due to a non existing command. When the framework doesn't have a port, we don't really have a good way to know when the framework command is ready. |
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes #3655
Also has netlify/framework-info#663
If the detected framework doesn't have a port, the CLI will still run the command, and fallback to using a static server.
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)