fix: function:serve shows undefined port in url

[karagulamos]

Summary

Fixes #4116

When a Netlify site is served using netlify functions:serve locally, the function URL shown at the terminal contains an undefined port which is incorrect albeit confusing to users when they click on it. This is caused by the use of an undefined NetlifyFunction:settings:port property composed within the NetlifyFunction:url (getter) property. This PR fixes the issue and includes relevant tests.

NOTE: Although I scoured the codebase for a valid usage of NetlifyFunction:settings:port to no avail, I’m not particularly fond of the current solution but left it there with comments (and for compatibility) should anyone wish to take a closer look.

[github-actions]

📊 Benchmark results

Comparing with 474118d

Package size: 362 MB

(no change)

^  360 MB  360 MB  360 MB  360 MB  360 MB  360 MB  360 MB  360 MB  360 MB  360 MB  360 MB  360 MB  362 MB 
│   ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    

Legend

• T-30 (474118d): 362 MB
• T-29 (045326c): 363 MB
• T-28 (49708c2): 363 MB
• T-27 (fa43ab8): 362 MB
• T-26 (4ffba32): 362 MB
• T-25 (fc1c991): 361 MB
• T-24 (a7c6aab): 361 MB
• T-23 (c2f4f1d): 361 MB
• T-22 (cc2c6dd): 361 MB
• T-21 (3d40fe1): 361 MB
• T-20 (1fcb0e3): 361 MB
• T-19 (e763556): 361 MB
• T-18 (be0bb11): 361 MB
• T-17 (d6d99d3): 361 MB
• T-16 (d5d421d): 361 MB
• T-15 (432774f): 360 MB
• T-14 (93b64cf): 360 MB
• T-13 (cd7af03): 360 MB
• T-12 (c8281ec): 360 MB
• T-11 (54040d8): 360 MB
• T-10 (1981515): 360 MB
• T-9 (434cdb7): 360 MB
• T-8 (c89d81a): 360 MB
• T-7 (0550e60): 360 MB
• T-6 (f1c4d10): 360 MB
• T-5 (50b3483): 360 MB
• T-4 (df33dd0): 360 MB
• T-3 (a41323f): 360 MB
• T-2 (b2b0faa): 360 MB
• T-1 (7d65669): 360 MB
• T (current commit): 362 MB

[lukasholzer]

Thx for adapting the tests! 🐳

[erezrokah]

@karagulamos, do you mind resolving the merge conflict? The test file was renamed in #4164

[erezrokah]

Going to approve per @lukasholzer review so we can merge this