Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph improvements #4169

Merged
merged 8 commits into from
Feb 3, 2022
Merged

Graph improvements #4169

merged 8 commits into from
Feb 3, 2022

Conversation

sgrove
Copy link
Contributor

@sgrove sgrove commented Feb 3, 2022

Summary

Incorporates feedback from users on the graph part of the cli to make improvements on framework detection, path detection, codegen, and adding some (temporary but useful during dev) netlify.toml options to override the defaults when necessary until we have that down solid.

@sgrove sgrove added the automerge Add to Kodiak auto merge queue label Feb 3, 2022
@kodiakhq kodiakhq bot merged commit c2f4f1d into netlify:main Feb 3, 2022
@erezrokah
Copy link
Contributor

erezrokah commented Feb 4, 2022

For future reference, for a commit to trigger a release (and to be included in the changelog) it should be prefixed by a fix: or a feat:.
This is evident by the failing conventionalcommits.org status check.

See more in https://github.com/googleapis/release-please/tree/bd74a5b7b622a6cec0d64cbf9b9e01102dc835b2#how-should-i-write-my-commits.

For this specific case I think fix: graph improvements would make sense (there's no action item here as this has already been released in https://github.com/netlify/cli/releases/tag/v8.15.4, but does appear in the changelog).

@sgrove
Copy link
Contributor Author

sgrove commented Feb 4, 2022

@erezrokah To be clear, when you say "it", are you referring to the commits, or to the title of the PR? I saw the evident failure of the conventionalcommits.org status check, but I thought my commits had followed the correct pattern, and it gave me no indication as to what the failure was.

If it's just the PR title, I'll be sure to follow that as well in the future.

@erezrokah
Copy link
Contributor

erezrokah commented Feb 4, 2022

If it's just the PR title, I'll be sure to follow that as well in the future.

It's both actually. If you have a single commit the PR title is taken from it by default, otherwise GitHub uses the branch name. Hence we validate both commit messages and PR titles.
The latter is important as if you have multiple commits the squash commit message it based on the PR title.

TLDR: what counts is the squash commit message, as it's used for changelog and release generation (and I don't know of a way to enforce the squash message format, so we try our best).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Add to Kodiak auto merge queue type: project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants