-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graph improvements #4169
Graph improvements #4169
Conversation
For future reference, for a commit to trigger a release (and to be included in the changelog) it should be prefixed by a For this specific case I think |
@erezrokah To be clear, when you say "it", are you referring to the commits, or to the title of the PR? I saw the evident failure of the If it's just the PR title, I'll be sure to follow that as well in the future. |
It's both actually. If you have a single commit the PR title is taken from it by default, otherwise GitHub uses the branch name. Hence we validate both commit messages and PR titles. TLDR: what counts is the squash commit message, as it's used for changelog and release generation (and I don't know of a way to enforce the squash message format, so we try our best). |
Summary
Incorporates feedback from users on the
graph
part of the cli to make improvements on framework detection, path detection, codegen, and adding some (temporary but useful during dev) netlify.toml options to override the defaults when necessary until we have that down solid.