Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass through cwd flag in getBuildOptions #4455

Merged
merged 1 commit into from
Mar 15, 2022
Merged

fix: pass through cwd flag in getBuildOptions #4455

merged 1 commit into from
Mar 15, 2022

Conversation

lourd
Copy link
Contributor

@lourd lourd commented Mar 15, 2022

Summary

Companion PR to opennextjs/opennextjs-netlify#1264, fixing opennextjs/opennextjs-netlify#1264.

Fixes a bug that causes an error when building a Next.js app in an Nx monorepo with the CLI and using the cwd option.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

I wasn't sure how/where this would be tested, would appreciate any pointers there.

A picture of a cute animal (not mandatory, but encouraged)

Screen Shot 2022-03-15 at 1 23 53 AM

Copy link
Contributor

@ehmicky ehmicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lourd,

Thanks a lot for this bug fix.
It looks good except for linting, which is currently failing. Running npm run format should fix it though. Thanks!

@lourd
Copy link
Contributor Author

lourd commented Mar 15, 2022

For sure! Fixed that, should be good to go.

@lourd lourd requested a review from ehmicky March 15, 2022 14:44
@ehmicky ehmicky added the type: bug code to address defects in shipped code label Mar 15, 2022
Copy link
Contributor

@ehmicky ehmicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@ehmicky ehmicky merged commit fa32955 into netlify:main Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants