-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: properly increase available ports #4666
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: chore
work needed to keep the product and development running smoothly
label
Jun 3, 2022
📊 Benchmark resultsComparing with 32a753d Package size: 294 MB(no change)
Legend
|
lukasholzer
approved these changes
Jun 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for cleaning this up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: ci
automerge
Add to Kodiak auto merge queue
type: chore
work needed to keep the product and development running smoothly
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting registry entries probably won't work, because usually a windows restart is required to apply the changes. So instead for the maximum ports use
netsh
command according to https://docs.microsoft.com/en-us/biztalk/technical-guides/settings-that-can-be-modified-to-improve-network-performanceI also changed the dev-server port detection in the tests to not calculate the static server port but instead get any available one from
get-port
. This way we can be a little bit more certain that the ports are actually free right before starting the dev server.Fixes #4654