-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: check for deno vs code ext and download when prompted #4698
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
2c40db9
fix: check for deno vs code ext and download when prompted
JWhist 7dcaf8d
fix: change execSync to use execa
JWhist bf428b7
fix: change execSync to use execa
JWhist 8c7a65f
fix: catch error during extension install to fix tests or if vscode nβ¦
JWhist 1e51be0
fix: add error catching
JWhist a375a68
fix: bypass prompt when error checking for deno
JWhist 59057d5
Merge branch 'main' into checkForDenoExt
JWhist f13c7be
Merge branch 'main' into checkForDenoExt
JWhist 809e223
fix: move error handling to single block
JWhist 8172bbe
fix: add stderr piping to execa command
JWhist 599053a
fix: add stderr piping to execa commands
JWhist 21777f6
fix: dot diff in test
JWhist 74e2a42
Merge branch 'main' into checkForDenoExt
JWhist bc21edf
Merge branch 'main' into checkForDenoExt
JWhist b761def
Update src/recipes/vscode/index.js
JWhist bd4ca72
Merge branch 'main' into checkForDenoExt
JWhist a4acb0e
chore: revert snapshot change
JWhist 6fadfee
Merge branch 'main' into checkForDenoExt
JWhist File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious why you've used
inherit
here and on L37?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to save the data from the extensions if the stdout is ok, but log the error to the screen if it is going to stderr.