Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: vendor wait-port to unblock CI #4783

Merged
merged 8 commits into from
Jul 11, 2022
Merged

chore: vendor wait-port to unblock CI #4783

merged 8 commits into from
Jul 11, 2022
+516 −9

Conversation

anmonteiro
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes #<replace_with_issue_number>

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

Sorry, something went wrong.

@anmonteiro
chore: vendor wait-port to unblock CI

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
2f36efa
@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label Jul 10, 2022
@anmonteiro @github-actions
chore: update contributors field

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
8f72d4f
@github-actions
Copy link

github-actions bot commented Jul 10, 2022 •
edited
Loading

📊 Benchmark results

Comparing with 13dd3a3

Package size: 227 MB

(no change)

^  227 MB  227 MB  227 MB  227 MB 
│   ┌──┐    ┌──┐    ┌──┐    ┌──┐  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴──>
    T-3     T-2     T-1      T
Legend

@anmonteiro
fix: e2e tests

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
cfb79ea
@anmonteiro anmonteiro mentioned this pull request Jul 11, 2022
Closed
@anmonteiro anmonteiro marked this pull request as ready for review July 11, 2022 01:24
@danez
Copy link
Contributor

danez commented Jul 11, 2022 •
edited
Loading

I guess we probably don't need to do this, because the pr is already merged, so hopefully there will be a release soon.
https://github.com/dwmkerr/wait-port/commits/main

They also dropped node 12 support in this bugfix version, so let's go for this and revert once we are on node 14 or newer.

@danez danez mentioned this pull request Jul 11, 2022
Closed
@danez danez added the automerge Add to Kodiak auto merge queue label Jul 11, 2022
@kodiakhq kodiakhq bot merged commit 9cefa25 into main Jul 11, 2022
@kodiakhq kodiakhq bot deleted the anmonteiro/vendor-wait-port branch July 11, 2022 10:00
danez added a commit that referenced this pull request Jul 11, 2022
@danez
Revert "chore: vendor wait-port to unblock CI (#4783)"
e77950a 
This reverts commit 9cefa25.

# Conflicts:
#	npm-shrinkwrap.json
#	package.json
@danez danez mentioned this pull request Jul 11, 2022
Merged
kodiakhq bot added a commit that referenced this pull request Jul 11, 2022
@danez @kodiakhq @token-generator-app
fix(deps): update wait-port to 0.2.14 (#4788)
302d31f 
* fix(deps): update wait-port to 0.2.14

* Revert "chore: vendor wait-port to unblock CI (#4783)"

This reverts commit 9cefa25.

# Conflicts:
#	npm-shrinkwrap.json
#	package.json

* chore: update contributors field

* chore: update contributors field

* chore: update contributors field

* chore: update contributors field

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: token-generator-app[bot] <token-generator-app[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danez danez

Assignees
No one assigned
Labels
automerge Add to Kodiak auto merge queue type: chore work needed to keep the product and development running smoothly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anmonteiro @danez