Dev: Fix port flag #488
Merged
Dev: Fix port flag #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i personally prefer we deprecate the |
DavidWells
approved these changes
Sep 13, 2019
|
@swyx What are the different port options right now. Would be nice to make them all similar and ultra clear on what they do. |
|
lets hust merge this in first and then work on port clarificaion. #563 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
The description for
portflag and its use in the script was conflicting. This change allows you to specify dev server port viaportflag.- Test plan
netlify dev --port 8085in your project dir- Description for the changelog
portflag forproxyPortportflag to specify dev server port- A picture of a cute animal (not mandatory but encouraged)
