Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Parcel detector #505

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Conversation

travishorn
Copy link
Contributor

@travishorn travishorn commented Sep 3, 2019

- Summary

The Netlify CLI does not currently detect the bundler Parcel. This pull request adds a detector to detect it.

- Test plan

Create the file src/index.html. At a minimum it should contain valid HTML.

Install parcel-bundler.

npm i -D parcel-bundler

Add a dev script in package.json.

"scripts": {
  "dev": "parcel src/index.html",
},

Run Netlify Dev.

netlify dev

Parcel bundles the project and serves a hot-reloading dev server on port 1234. Netlify Dev proxies it on port 8888.

PS C:\Users\thorn\Development\netlifytest> netlify dev

◈ Netlify Dev ◈
◈ Starting Netlify Dev with parcel
Waiting for localhost:1234.
◈ Lambda server is listening on 34567

> netlifytest@2.2.4 dev C:\Users\thorn\Development\netlifytest
> parcel src/index.html

Server running at http://localhost:1234 
√  Built in 673ms.
.
Connected!
Waiting for localhost:34567.
Connected!

   ┌─────────────────────────────────────────────────┐
   │                                                 │
   │   ◈ Server now ready on http://localhost:8888   │
   │                                                 │
   └─────────────────────────────────────────────────┘

- Description for the changelog

Added Parcel detector

- A picture of a cute animal (not mandatory but encouraged)
🐱

Copy link
Contributor

@RaeesBhatti RaeesBhatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems good to merge. Thanks 👍🏽

@RaeesBhatti RaeesBhatti merged commit f569721 into netlify:master Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants