-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add debug logs to config resolution #5162
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: chore
work needed to keep the product and development running smoothly
label
Oct 12, 2022
📊 Benchmark resultsComparing with dc75103 Package size: 230 MB⬇️ 0.00% decrease vs. dc75103
Legend
|
akahn
previously approved these changes
Oct 12, 2022
JGAntunes
force-pushed
the
chore/debug-logs-for-config-resolution
branch
from
October 12, 2022 16:33
bd8ea85
to
4786477
Compare
JGAntunes
changed the title
chore: add debug logs to config resolution
fix: add debug logs to config resolution
Oct 12, 2022
akahn
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automerge
Add to Kodiak auto merge queue
type: bug
code to address defects in shipped code
type: chore
work needed to keep the product and development running smoothly
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Follow up to - https://github.com/netlify/bitballoon/issues/13488 - currently we fallback to offline config resolution if we get back an error from
@netlify/config
which we classify as an user error. This PR adds debug logs that log the output of said error.For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)