chore: remove unnecessary abstractions of filesystem functions #5320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danez
commented
Dec 16, 2022
| import execa from 'execa' | ||
| import getPort from 'get-port' | ||
| import verdaccio from 'verdaccio' | ||
|
|
||
| // TODO: remove this once `../../src/lib/fs.js` is an esm module as well |
There was a problem hiding this comment.
Don't know why we should wait, ESM can import commonjs
danez
commented
Dec 16, 2022
| @@ -1,22 +1,15 @@ | |||
| import { appendFileSync, existsSync, promises, readFileSync, writeFileSync } from 'fs' | |||
| import { appendFile, mkdtemp, readFile, rm, writeFile } from 'fs/promises' | |||
There was a problem hiding this comment.
I updated this file to use async version of the fs functions.
📊 Benchmark resultsComparing with 6102e77 Package size: 249 MB⬇️ 0.00% decrease vs. 6102e77 Legend
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Both
readFileAsyncCatchErrorandrmdirRecursiveAsyncfromsrc/lib/fs.cjscan be replaced with node builtin functionality now that we dropped node 12.