-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: load internal environment variables in Envelope #5429
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Benchmark resultsComparing with b0a6c85 Package size: 265 MB(no change)
Legend
|
khendrikse
approved these changes
Jan 24, 2023
Thanks @eduardoboucas!! Once all sites are migrated to Envelope in Feb/March, we can delete a lot of code from the CLI that juggles env vars between the two systems. I'm looking forward to it 🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#5338 has changed the way the
NETLIFY_DEV
environment variable is set. Rather than mutatingprocess.env
immediately, we set a variable in theenv
object with the typeinternal
, which is processed as a type of environment variable that can't be overridden.Unfortunately, this wasn't added to the Envelope methods, and so the variable was being removed for sites with Envelope enabled.
This PR addresses that and adds some tests (to both legacy and new environment variable systems) to ensure we don't introduce this regression again.