feat: add generator to functions config on deploy #5483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khendrikse
added
the
type: feature
📊 Benchmark resultsComparing with f6f9cf9 Package size: 263 MB⬇️ 0.00% decrease vs. f6f9cf9 Legend
|
eduardoboucas
approved these changes
Feb 17, 2023
| })) | ||
| const fnConfig = functionZips | ||
| .filter((func) => Boolean(func.displayName)) | ||
| .reduce((funcs, curr) => ({ ...funcs, [curr.name]: { display_name: curr.displayName } }), {}) | ||
| .filter((func) => Boolean(func.displayName || func.generator)) |
There was a problem hiding this comment.
This is starting to get a bit gnarly. I think we should consider abstracting this into a new function that holds the list of properties we accept and does the normalisation.
Totally fine to do in a future PR, though.
There was a problem hiding this comment.
Taking this comment seriously but also I couldn't help but hear it as a surferdude 😆
khendrikse
deleted the
feat-415/add-generator-to-functions-config-on-deploy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Work for https://github.com/netlify/pod-compute/issues/350
Making sure that the generator field is passed along to the functions_config field we send to bitballoon.
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)
