Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency p-wait-for to v5 #5632

Merged
merged 3 commits into from
Apr 14, 2023
Merged

fix(deps): update dependency p-wait-for to v5 #5632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38f393c
fix(deps): update dependency p-wait-for to v5
renovate[bot] Apr 14, 2023
3fb4bc0
chore: remove usage of pWaitFor and fix usage
danez Apr 14, 2023
3bdeb35
Merge branch 'main' into renovate/p-wait-for-5.x
kodiakhq[bot] Apr 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 20 additions & 23 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@
"ora": "^6.0.0",
"p-filter": "^3.0.0",
"p-map": "^5.0.0",
"p-wait-for": "^3.0.0",
"p-wait-for": "^5.0.0",
"parallel-transform": "^1.2.0",
"parse-github-url": "^1.0.2",
"parse-gitignore": "^2.0.0",
Expand Down
6 changes: 4 additions & 2 deletions src/commands/watch/watch.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,10 @@ const waitForBuildFinish = async function (api, siteId, spinner) {

await pWaitFor(waitForBuildToFinish, {
interval: BUILD_FINISH_INTERVAL,
timeout: BUILD_FINISH_TIMEOUT,
message: 'Timeout while waiting for deploy to finish',
timeout: {
milliseconds: BUILD_FINISH_TIMEOUT,
message: 'Timeout while waiting for deploy to finish',
},
})

// return only when build done or timeout happens
Expand Down
13 changes: 9 additions & 4 deletions src/utils/deploy/util.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// @ts-check
import { sep } from 'path'

import pWaitFor from 'p-wait-for'
Expand Down Expand Up @@ -43,8 +44,10 @@ export const waitForDiff = async (api, deployId, siteId, timeout) => {

await pWaitFor(loadDeploy, {
interval: DEPLOY_POLL,
timeout,
message: 'Timeout while waiting for deploy',
timeout: {
milliseconds: timeout,
message: 'Timeout while waiting for deploy',
},
})

return deploy
Expand Down Expand Up @@ -80,8 +83,10 @@ export const waitForDeploy = async (api, deployId, siteId, timeout) => {

await pWaitFor(loadDeploy, {
interval: DEPLOY_POLL,
timeout,
message: 'Timeout while waiting for deploy',
timeout: {
milliseconds: timeout,
message: 'Timeout while waiting for deploy',
},
})

return deploy
Expand Down
2 changes: 1 addition & 1 deletion src/utils/live-tunnel.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ export const startLiveTunnel = async ({ localPort, netlifyApiToken, siteId }) =>
return data.state === 'online'
}

await connectTunnel({ session, netlifyApiToken, localPort })
connectTunnel({ session, netlifyApiToken, localPort })

// Waiting for the live session to have a state of `online`.
await pWaitFor(isLiveTunnelReady, {
Expand Down
Loading