-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace ava with vitest and esm #5836
refactor: replace ava with vitest and esm #5836
Conversation
…thub.com/hereje/cli into refactor/replace-ava-with-vitest-and-esm
Hey @hereje thanks for taking this big effort for us! By that, we can simpler review it and you can avoid merge conflicts easier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And maybe move the files in the location of the specific commands.
Like tests/integration/100.command.dev.test.cjs
-> tests/integration/commands/dev/dev.test.mjs`
|
||
const test = isCI ? avaTest.serial.bind(avaTest) : avaTest | ||
// FIXME: Run tests serial |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course. I'll do it!
🎉 Thanks for submitting a pull request! 🎉
Summary
Convert all test files from commonjs to ESM
Fixes #5698
test:dev:ava
,test:ci:ava:integration
frompackage.json
because they are no longer needed.package.json
Pending activities:
watch
script onpackage.json
'ava/no-import-test-files': 'off',
on.eslintrc.cjs
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)