EF: Don't crash CLI when uncompressed request throws uncaught exception #5837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
approved these changes
Jul 5, 2023
| * @param {string | undefined} contentEncoding | ||
| * @returns {Promise<Buffer>} | ||
| */ | ||
| const decompressResponseBody = async function (body, contentEncoding = '') { |
There was a problem hiding this comment.
Will this handle the case where content-encoding contains multiple values, like deflate, gzip?
There was a problem hiding this comment.
It won't, but I don't think that case exists for uncaught exceptions. This code path only occurs when x-nf-uncaught-error is set. The content-encoding is added by Deno automatically: https://deno.land/manual@v1.20.1/runtime/http_server_apis#automatic-body-compression
I don't think they ever combine compressions, so not supporting multiple values should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes https://github.com/netlify/pod-dev-foundations/issues/536
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)