Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ef error page should have 500 status code #5838

Merged
merged 1 commit into from
Jul 5, 2023
Merged

fix: ef error page should have 500 status code #5838

merged 1 commit into from
Jul 5, 2023

Conversation

Skn0tt
Copy link
Contributor

@Skn0tt Skn0tt commented Jul 5, 2023

Currently, we're returning a 200 status code for the error page. This PR changes that to a 500.

@Skn0tt Skn0tt self-assigned this Jul 5, 2023
@Skn0tt Skn0tt requested a review from a team as a code owner July 5, 2023 09:10
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

📊 Benchmark results

Comparing with f7291d1

  • Dependency count: 1,312 (no change)
  • Package size: 278 MB (no change)

eduardoboucas
eduardoboucas approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Skn0tt Skn0tt merged commit f982cf0 into main Jul 5, 2023
@Skn0tt Skn0tt deleted the ef-error-page-50 branch July 5, 2023 13:14
@token-generator-app token-generator-app bot mentioned this pull request Jul 5, 2023
Merged
@ReyBan82 ReyBan82 mentioned this pull request Oct 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduardoboucas eduardoboucas eduardoboucas approved these changes

Assignees

@Skn0tt Skn0tt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Skn0tt @eduardoboucas