refactor: tests/integration/20.command.functions.test.cjs #5889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor test file to ESM - convert to ESM - replace ava with vitest - replace got with node-fetch Related to: netlify#5698
lukasholzer
previously approved these changes
Jul 26, 2023
| .buildAsync() | ||
|
|
||
| await withFunctionsServer({ builder }, async () => { | ||
| const response = await fetch(`http://localhost:9999/.netlify/functions/ping`) |
There was a problem hiding this comment.
Thanks for using fetch and getting rid of got!
| await builder | ||
| .withNetlifyToml({ | ||
| config: { | ||
| build: { environment: { VITEST_TEST: 'FROM_CONFIG_FILE' } }, |
There was a problem hiding this comment.
NIT: As mentioned in the other PR I would not rename the variable to something that could be set by vitest (to avoid having it set from the testrunner)
I would rename it to something like MY_CONFIG
hereje
deleted the
refactor_test_esm/tests/integration/20.command.functions.test.cjs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor test file to ESM
Summary
Related to: #5698
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)