Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 130.eleventy.test.cjs #5894

Merged
merged 11 commits into from
Jul 28, 2023
Merged

refactor: 130.eleventy.test.cjs #5894

merged 11 commits into from
Jul 28, 2023

Conversation

hereje
Copy link
Contributor

@hereje hereje commented Jul 26, 2023 •
edited
Loading

Summary

  • convert file to ESM
  • replace ava with vitest
  • replace got with node-fetch
  • rename and move file

Related to: #5698

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@hereje
refactor: 130.eleventy.test.cjs
4b8d83f 
- convert file to ESM
- replace ava with vitest
- replace got with node-fetch
- rename and move file

Related to: netlify#5698
@hereje hereje requested a review from a team as a code owner July 26, 2023 06:17
@github-actions
Copy link

github-actions bot commented Jul 26, 2023 •
edited
Loading

📊 Benchmark results

Comparing with 0897962

  • Dependency count: 1,303 (no change)
  • Package size: 271 MB (no change)

hereje added 8 commits July 27, 2023 10:45
@hereje
Merge branch 'main' into refactor_test_esm/tests/integration/130.elev…
8135127 
…enty.test.cjs
@hereje
refactor: 130.eleventy.test.cjs
9c5fdbb 
- convert file to ESM
- replace ava with vitest
- replace got with node-fetch
- rename and move file

Related to: netlify#5698
@hereje
Merge branch 'refactor_test_esm/tests/integration/130.eleventy.test.c…
04e56ef 
…js' of https://github.com/hereje/cli into refactor_test_esm/tests/integration/130.eleventy.test.cjs
@hereje
fix: update cwd path on startDevServer
6aa9210
@hereje
test: run tests concurrently
67f7188
@hereje
test: remove skip on test with technical debt
4ca1f95 
- remove skip on test due to the fact that the issue
commented in technical debt is already solved
@hereje
fix: match with most of the original test headers
bdaf120
@hereje
style: headers reorganization
259365a
@sarahetter sarahetter added the automerge Add to Kodiak auto merge queue label Jul 28, 2023
@kodiakhq kodiakhq bot merged commit d8228d8 into netlify:main Jul 28, 2023
@hereje hereje deleted the refactor_test_esm/tests/integration/130.eleventy.test.cjs branch July 28, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahetter sarahetter sarahetter approved these changes

Assignees
No one assigned
Labels
automerge Add to Kodiak auto merge queue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hereje @sarahetter