Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete tests/integration/320.command.help.test.cjs #5903

Merged
merged 1 commit into from
Jul 28, 2023
Merged

delete tests/integration/320.command.help.test.cjs #5903

merged 1 commit into from
Jul 28, 2023

Conversation

hereje
Copy link
Contributor

@hereje hereje commented Jul 27, 2023 •
edited
Loading

Summary

  • remove test file and associated snapshots.
  • The test is already implemented in tests/integration/commands/help/help.test.ts

Related to: #5698

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@hereje
refactor: remove already implemented test
0a3fd78 
- remove test file and associated snapshots
the test is laready implemented in
`tests/integration/commands/help/help.test.ts`
@hereje hereje requested a review from a team as a code owner July 27, 2023 18:56
@github-actions
Copy link

📊 Benchmark results

Comparing with 829ee1a

  • Dependency count: 1,303 (no change)
  • Package size: 271 MB ⬇️ 0.00% decrease vs. 829ee1a

@hereje hereje changed the title refactor_test_esm/tests/integration/320.command.help.test.cjs delete tests/integration/320.command.help.test.cjs Jul 27, 2023
@sarahetter sarahetter added the automerge Add to Kodiak auto merge queue label Jul 28, 2023
@kodiakhq kodiakhq bot merged commit 0897962 into netlify:main Jul 28, 2023
@hereje hereje deleted the refactor_test_esm/tests/integration/320.command.help.test.cjs branch July 28, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahetter sarahetter sarahetter approved these changes

Assignees
No one assigned
Labels
automerge Add to Kodiak auto merge queue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hereje @sarahetter