Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: tests/integration/didyoumean.test.cjs #5912

Conversation

hereje
Copy link
Contributor

@hereje hereje commented Jul 31, 2023

Summary

  • refactor: file reorganization for didyoumean test
  • refactor: convert file to ESM
  • refactor: replace ava with vitest
  • style: apply lint rules

Related to: #5698


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

hereje added 4 commits July 31, 2023 14:30
- rename test file
- move snapshot files to new destination
- replace ava with vitest
- adjust tests accordingly
- update snapshots
@hereje hereje requested a review from a team as a code owner July 31, 2023 20:51
@github-actions
Copy link

github-actions bot commented Jul 31, 2023

📊 Benchmark results

Comparing with 0fc2bad

  • Dependency count: 1,303 (no change)
  • Package size: 271 MB ⬇️ 0.00% decrease vs. 0fc2bad

@sarahetter sarahetter added the automerge Add to Kodiak auto merge queue label Aug 2, 2023
@kodiakhq kodiakhq bot merged commit 07d3111 into netlify:main Aug 2, 2023
@hereje hereje deleted the refactor_test_esm/tests/integration/didyoumean.test.cjs branch August 2, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Add to Kodiak auto merge queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants