Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add flag that allows us to control al2 rollout independent of buildbot #6021

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

Skn0tt
Copy link
Contributor

@Skn0tt Skn0tt commented Sep 22, 2023

Summary

As explained in https://github.com/netlify/pod-dev-foundations/issues/581#issuecomment-1731022753, enabling the zisi_golang_use_al2 flag will lead to failures in versions of the CLI that don't have the #6020 patch. That means we need to decouple the rollout of zisi_golang_use_al2 in buildbot (where @netlify/build is always up-to-date) from the rollout in the CLI, where the flag also affects versions with broken behaviour. That's why this PR adds a second flag, which we can use to control the CLI rollout independently.

Part of https://github.com/netlify/pod-dev-foundations/issues/581


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@Skn0tt Skn0tt requested a review from a team as a code owner September 22, 2023 08:36
@Skn0tt Skn0tt self-assigned this Sep 22, 2023
@github-actions
Copy link

github-actions bot commented Sep 22, 2023

📊 Benchmark results

Comparing with 6aa53d6

  • Dependency count: 1,365 (no change)
  • Package size: 366 MB (no change)

@Skn0tt Skn0tt enabled auto-merge (squash) September 22, 2023 13:15
@Skn0tt Skn0tt merged commit c498ed3 into main Sep 22, 2023
63 checks passed
@Skn0tt Skn0tt deleted the control-al2-flag-independently-of-buildbot branch September 22, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants