Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add file-based blob support to netlify dev #6458

Conversation

ndhoule
Copy link
Contributor

@ndhoule ndhoule commented Mar 20, 2024

Depends on netlify/build#5552.

The changes in that PR were released in bb08e3f, so this is no longer a feature PR but is now just adding a test that covers this functionality.

Fixes CT-651.

@ndhoule ndhoule changed the title Nathanhoule/ct 651 blobs client should read from file based upload folder feat: add file-based blob support in netlify dev Mar 20, 2024
@ndhoule ndhoule changed the title feat: add file-based blob support in netlify dev feat: add file-based blob support to netlify dev Mar 20, 2024
Copy link

github-actions bot commented Mar 20, 2024

📊 Benchmark results

Comparing with bb08e3f

  • Dependency count: 1,308 (no change)
  • Package size: 294 MB (no change)
  • Number of ts-expect-error directives: 1,017 ⬇️ 1.18% decrease vs. bb08e3f

@ndhoule ndhoule force-pushed the nathanhoule/ct-651-blobs-client-should-read-from-file-based-upload-folder branch from 0f22a18 to 892e588 Compare April 4, 2024 20:31
@ndhoule ndhoule marked this pull request as ready for review April 4, 2024 21:16
@ndhoule ndhoule requested a review from a team as a code owner April 4, 2024 21:16
@ndhoule ndhoule changed the title feat: add file-based blob support to netlify dev test: add file-based blob support to netlify dev Apr 4, 2024
@ndhoule ndhoule merged commit 5557ce1 into main Apr 4, 2024
40 checks passed
@ndhoule ndhoule deleted the nathanhoule/ct-651-blobs-client-should-read-from-file-based-upload-folder branch April 4, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants