Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip test on windows due to unexpected fetch behaviour #6624

Merged
merged 1 commit into from
May 17, 2024

Conversation

mrstork
Copy link
Contributor

@mrstork mrstork commented May 17, 2024

Summary

Fixes tests for #6235
See discussion for more information on the behaviour

We opted to skip the test on windows as edge functions will not be hosted on windows machines in production, and during local development there is no need for a short refresh window (< 1s)

Confirmed test passes / gets skipped on windows with these changes


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

@mrstork mrstork requested a review from a team as a code owner May 17, 2024 02:31
Copy link

github-actions bot commented May 17, 2024

📊 Benchmark results

Comparing with c8559fe

  • Dependency count: 1,359 (no change)
  • Package size: 313 MB (no change)
  • Number of ts-expect-error directives: 983 (no change)

@mrstork mrstork force-pushed the skip-miscellaneous-test-on-windows branch 2 times, most recently from 58dd3fe to 2d6c300 Compare May 17, 2024 12:06
@mrstork mrstork force-pushed the skip-miscellaneous-test-on-windows branch from 2d6c300 to 82bace6 Compare May 17, 2024 12:08
@sarahetter sarahetter added the automerge Add to Kodiak auto merge queue label May 17, 2024
@kodiakhq kodiakhq bot merged commit c82114c into main May 17, 2024
46 checks passed
@kodiakhq kodiakhq bot deleted the skip-miscellaneous-test-on-windows branch May 17, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Add to Kodiak auto merge queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants