feat: rename next.js adapter package #6896
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're not calling it a "runtime" anymore. Plus this was super leaky anyway, assuming that any auto-installed build plugin is a "runtime".
serhalp
reviewed
Oct 23, 2024
| @@ -34,7 +34,7 @@ export const getPluginsToAutoInstall = ( | |||
| pluginsInstalled: string[] = [], | |||
| pluginsRecommended: string[] = [], | |||
| ) => { | |||
| const nextRuntime = '@netlify/plugin-nextjs' | |||
| const nextRuntime = '@opennextjs/netlify' | |||
There was a problem hiding this comment.
This took me a while to understand — this is part of 'init' i.e. used in ntl init and related scenarios, and its purpose is to literally auto-install the plugin on the site via the Netlify API if it isn't already installed and we've detected that it should be. So it's OK to just update this name and not "handle" the old name in any way.
There was a problem hiding this comment.
... although, wait, isn't there a case like this?
- next.js site exists today with @netlify/plugin-nextjs installed
- we release this cli change
- user clones their repo, runs
ntl init, it checks and finds that@opennextjs/netlifyis not auto-installed (even though@netlify/plugin-nextjsis) and auto-installs@opennextjs/netlify. - user has both plugins installed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update to use new package name for our Next.js Adapter, which is moving to the @opennextjs scope.
To do