Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev] Add support for injecting shared environment variables #699

Merged

Conversation

eddiecooro
Copy link
Contributor

@eddiecooro eddiecooro commented Feb 7, 2020

Fixes #431

@eddiecooro eddiecooro requested a review from a team as a code owner February 7, 2020 14:11
@erquhart
Copy link
Contributor

erquhart commented Feb 24, 2020

Thanks for opening this @Eddie-CooRo!

@RaeesBhatti the approach here seems reasonable - I'll defer to you on review in case there's a non-obvious issue. Would be worth adding some testing around this and existing env var injection, too, but no need to block this PR for it.

@erquhart erquhart requested a review from RaeesBhatti February 24, 2020 19:10
@eddiecooro
Copy link
Contributor Author

Hey @erquhart thanks for your reply
@RaeesBhatti have you seen any issue in this PR? We upgraded our account to pro just because of shared env variables, and netlify dev not supporting it is a little troublesome for us. because of this, I have to use a custom build of this package for our team, and using the awesome features you guys are working on, needs some rebasing and dirty works.
It would be great if we could have this feature in the official package.
thanks in forward.

Copy link
Contributor

@RaeesBhatti RaeesBhatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Eddie-CooRo, thanks for opening this PR. It took longer than it should've but we've confirmed the intended behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't access Shared environment variables from netlify dev
3 participants