Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

instead of using CWD use '.' for deploying the root dir #8

Closed
wants to merge 1 commit into from
Closed

instead of using CWD use '.' for deploying the root dir #8

wants to merge 1 commit into from

Conversation

rybit
Copy link
Member

@rybit rybit commented Aug 1, 2016

No description provided.

@calavera
Copy link
Contributor

calavera commented Aug 1, 2016

why? This is not portable and it won't work on Windows.

@rybit
Copy link
Member Author

rybit commented Aug 1, 2016

Otherwise you record the current directory ~ which means that if you move that dir it is going to break.

@biilmann
Copy link
Member

biilmann commented Aug 1, 2016

What would be the equivalent on windows? Actually hoped the . might work, we might need to make the empty string work otherwise

@calavera
Copy link
Contributor

calavera commented Aug 1, 2016

which means that if you move that dir it is going to break.

Sorry, I'm not familiar with this implementation. Where are we recording that path? is the path absolute?

@rybit
Copy link
Member Author

rybit commented Aug 1, 2016

yeah it used to record the cwd in the .netlify file

@biilmann
Copy link
Member

biilmann commented Aug 1, 2016

We're storing the path in the .netlify config file. The issue is when there's no path specified and we fall back to process.cwd() and that ends up being an absolute path (where obviously .netlify ought to store a relative path.

@calavera
Copy link
Contributor

calavera commented Aug 1, 2016

Store a relative path to the .netlify file and expand when it's necessary. Don't store anything if result.path is empty.

@rybit
Copy link
Member Author

rybit commented Aug 1, 2016

that means that each time you deploy you'll be asked what dir you want to deploy.

@rybit rybit closed this May 17, 2018
@rybit rybit deleted the update_cli_to_deploy_cwd branch May 17, 2018 15:54
@renovate renovate bot mentioned this pull request Nov 1, 2021
Closed
1 task
eduardoboucas added a commit that referenced this pull request Apr 18, 2022
@eduardoboucas
feat: add support for Edge Functions (#8)
c31ecb5 
* chore: change package details

* chore: update package

* chore: bump

* chore: add @netlify/edge-bundler

* chore: bump

* chore: remove npmrc line

* chore: bump version

* chore: update @netlify/edge-bundler

* feat: deploy Edge Handlers to internal path

* feat: add local development experience

* chore: bump version

* chore: update @netlify/edge-bundler

* refactor: move `watcher` util

* feat: add `configWatcher`

* feat: updates to Edge Handlers dev server

* chore: update @netlify/edge-bundler

* refactor: remove unused error binding

* chore: update package name

* chore: update deps

* fix: use correct URL path when matching Edge Handlers

* chore: bump version

* chore: bump version

* feat: add support for internal handlers in local dev (#1)

* feat: add support for internal handlers in local dev

* refactor: correctly merge declarations

* chore: bump version

* fix: run config watcher only on certain commands (#2)

* chore: bump version

* chore: bump version

* feat: add support for user import maps (#3)

* feat: add support for user import maps

* feat: warn when failing to read import map file

* chore: bump version

* chore: bump version

* fix: improve error handling for Edge Handlers (#4)

* chore: bump version

* feat: listen for `NETLIFY_DENO_DEBUG` environment variable (#5)

* feat: listen for `NETLIFY_DENO_DEBUG` environment variable

* chore: upgrade @netlify-labs/edge-bundler

* chore: bump version

* fix: use `0.0.0.0` for Deno server host (#6)

* fix: wait for Edge Handlers server to become available (#7)

* fix: wait for Edge Handlers server to become available

* refactor: wait for server inside request

* refactor: increase timeout

* refactor: use watcher from correct location

* chore: update package.json

* chore: disable release-please

* feat: replace @netlify/build with @netlify-labs/build-internal

* chore: use token in CI

* refactor: use existing config watcher

* chore: remove unused variables

* chore: remove actions

* chore: remove action

* chore: update test

* chore: add tests

* chore: move env to job

* chore: remove duplicate env

* chore: fix tests

* chore: remove unused imports

* fix: check if EH directory exists before deploy

* feat: rename Edge Handlers to Edge Functions (#9)

* chore: fix linting issue

* chore: fix tests

* chore: fix test

* chore: add `withEdgeFunction` test helper

* chore: remove `console.log`

* refactor: remove old Edge Handlers code

* chore: update packages

* fix: remove reference to traffic-mesh

* chore: fix linting issue

* chore: fix linting issue

* refactor: remove unused code

* refactor: remove `dev:trace` command

* chore: setup Deno in the CI

* refactor: use different localhost IP

* chore: simplify test

* chore: simplify test
@renovate renovate bot mentioned this pull request Oct 17, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rybit @calavera @biilmann