Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev: Rewrite for internal URL with SPA servers #810

Merged
merged 6 commits into from
Apr 9, 2020
Merged

Dev: Rewrite for internal URL with SPA servers #810

merged 6 commits into from
Apr 9, 2020

Conversation

RaeesBhatti
Copy link
Contributor

@RaeesBhatti RaeesBhatti commented Apr 9, 2020 •
edited
Loading

- Summary
Fixes: #794

- Test plan
Run netlify dev in a create-react-app project with some functions and following redirect rules:

/api/*      /.netlify/functions/:splat  200

- Description for the changelog

  • Rewrite URLs for SPA apps if the target URL starts with /.netlify/

- A picture of a cute animal (not mandatory but encouraged)
🐲

@RaeesBhatti RaeesBhatti requested review from ehmicky and erezrokah April 9, 2020 00:51
@RaeesBhatti RaeesBhatti merged commit d501a32 into master Apr 9, 2020
@RaeesBhatti RaeesBhatti deleted the raees/internal-redirect branch April 9, 2020 17:09
@erezrokah erezrokah mentioned this pull request Sep 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erezrokah erezrokah erezrokah approved these changes

@ehmicky ehmicky ehmicky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Netlify Dev /* 200 redirect not working
3 participants
@RaeesBhatti @ehmicky @erezrokah