-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add error state to onAfterDownload #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I was wondering if it would make more sense to supply the error directly to the function instead of the boolean, but there is only one kind of error and I also don't really see a usecase for that. So I think this is fine the way it is.
Agreed! It seems to me that the amount of work of adding a |
…tlify/edge-bundler into fix/add-error-state-to-after-download
… shortened link Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>
* fix: add error state to after download Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>
🎉 Thanks for sending this pull request! 🎉
Please make sure the title is clear and descriptive.
If you are fixing a typo or documentation, please skip these instructions.
Otherwise please fill in the sections below.
Which problem is this pull request solving?
Adds error state to onAfterDownload to allow for icon change in case there is an issue with deno binary download or installation
List other issues or pull requests related to this problem
Checklist
Please add a
x
inside each checkbox:A picture of a cute animal (not mandatory but encouraged)