feat: add custom rate limit types #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulo
added
the
type: feature
Skn0tt
previously approved these changes
May 16, 2024
eduardoboucas
previously approved these changes
May 16, 2024
src/function/v2.ts
Outdated
| interface RateLimitConfig { | ||
| action?: RateLimitAction | ||
| aggregateBy?: RateLimitAggregator | RateLimitAggregator[] | ||
| algorithm?: RateLimitAlgorithm |
There was a problem hiding this comment.
Why do we have this property if sliding_window is the only possible value?
There was a problem hiding this comment.
Great point, I've removed it!
eduardoboucas
approved these changes
May 16, 2024
paulo
pushed a commit
that referenced
this pull request
May 16, 2024
🤖 I have created a release *beep* *boop* --- ## [2.7.0](v2.6.3...v2.7.0) (2024-05-16) ### Features * add custom rate limit types ([#500](#500)) ([00e262a](00e262a)) ### Bug Fixes * **deps:** update dependency @netlify/serverless-functions-api to v1.18.1 ([#497](#497)) ([cd92ae9](cd92ae9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: token-generator-app[bot] <82042599+token-generator-app[bot]@users.noreply.github.com>
This was referenced Jun 7, 2024
This was referenced Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base types for custom rate limit config type inference (almost forgot). Basically a dried out version of https://github.com/netlify/zip-it-and-ship-it/blob/main/src/rate_limit.ts, but let me know if you think I should just use the original one instead.
Related to ADN-294
Will do the same for edge-functions after this one gets through