Skip to content
This repository has been archived by the owner on May 10, 2021. It is now read-only.

Catch-all routes #1

Closed
wants to merge 0 commits into from
Closed

Catch-all routes #1

wants to merge 0 commits into from

Conversation

spencewood
Copy link
Contributor

@alxhghs
Copy link

alxhghs commented Mar 15, 2020

I forked this branch to use for my current site which has catchall routes and I can attest to it seeming to work well. Seems like this would be good to add! Once it's merged in I'll be able to remove my fork :) thanks for this

@Yagogc
Copy link

Yagogc commented Mar 16, 2020

Please mind a silly question @spencewood :

I'm having issues with next-on-netlify by getting query params from getServerSideProps. Does this PR fix that issue? (Note: the same app works in now.sh, so I guess the issue relates to Netlify and this plugin)

Thanks!

@spencewood
Copy link
Contributor Author

I believe the issue with netlify and getServerSideProps is due to the fact that Next returns the server side props with this new method in a separate .json request instead of including it in the body like getInitialProps. Some additional rewriting or routing would need to be included to support this, but this particular change does not address it.

@FinnWoelm
Copy link
Collaborator

Hi @spencewood and @alxhghs,

this is great! 🙌 Thank for you opening this pull request.

Sorry for taking so long to get back. Somehow this totally slipped my attention. I'm on it now and will hopefully merge the changes today. 🚀

I'll keep you posted.

PS: @Yagogc, thanks for pointing out the issue with getServerSideProps. I'll look into that.

FinnWoelm added a commit to netlify/next-on-netlify-demo that referenced this pull request Apr 19, 2020
Update next-on-netlify to the version proposed in PR #1:
netlify/next-on-netlify#1

This adds support for NextJS catch-all routes.
@FinnWoelm FinnWoelm closed this Apr 19, 2020
@FinnWoelm
Copy link
Collaborator

Oh no, I was adding some commits to this PR and messed up a forced push. 😬

It automatically closed this PR and I can't reopen this one. I've repushed the commits to a new PR (#5). Sincere apologies about that... 😭

FinnWoelm added a commit that referenced this pull request Apr 19, 2020
- Add support for catch-all routes (#1, #2)
- README: Fix instructions for local preview
FinnWoelm added a commit that referenced this pull request Apr 19, 2020
- Add support for catch-all routes (#1, #2)
- README: Fix instructions for local preview
@FinnWoelm
Copy link
Collaborator

Happy to say that the latest release of next-on-netlify (v1.1.0) brings full support for catch-all routing! Check it out: https://next-on.netlify.app/shows/73/whatever/path/you/want

Thank you @spencewood and @alxhghs for your excellent contributions (and sorry again for messing up this PR... 🙈)

@FinnWoelm
Copy link
Collaborator

Hey @Yagogc,

I know it's been a while, but I'm happy to report that next-on-netlify finally supports both getServerSideProps and getStaticProps 😁 🎉

Here's the full list of changes for next-on-netlify v2.0.0: https://github.com/FinnWoelm/next-on-netlify/blob/master/CHANGELOG.md#200-2020-06-02

Let me know if you have any questions or run into any issues!

Happy hacking 🔥
Finn

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants