Skip to content
This repository has been archived by the owner on May 10, 2021. It is now read-only.

Add finished to res #117

Merged
merged 2 commits into from
Dec 14, 2020
Merged

Add finished to res #117

merged 2 commits into from
Dec 14, 2020

Conversation

JoviDeCroock
Copy link
Contributor

@JoviDeCroock JoviDeCroock commented Dec 14, 2020

This signals to Next that we aren't expecting any props to be returned in getServersideProps or getInitialProps

Fixes: #116

I might've made a mistake to submit this PR from the GH-edit-UI, the labels didn't carry over 😅

I've also added writeableEnded because finished is deprecated

This signals to Next that we aren't expecting any props to be returned in `getServersideProps` or `getInitialProps`
@lindsaylevine lindsaylevine added the type: bug code to address defects in shipped code label Dec 14, 2020
@lindsaylevine lindsaylevine merged commit 818cb91 into netlify:main Dec 14, 2020
@JoviDeCroock JoviDeCroock deleted the patch-1 branch December 14, 2020 15:46
lindsaylevine added a commit that referenced this pull request Jan 3, 2021
- Support for i18n in Next 10 ([#75](#75))
- dependabot: node-notifier from 8.0.0 to 8.0.1 ([#125](#125))
- Expose Netlify function params as netlifyFunctionParams ([#119](#119))
- Fix: local cypress cache control ([#118](#118))
- Fix: add res.finished to createResponseObject ([#117](#117))
- Fix: Windows support ([#101](#101))
- Improve logs for specified functions/publish dirs ([#100](#100))
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirecting from "getInitialProps" puts the response in html
2 participants