chore: upgrade to blobs v8 #2595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Package size report 0.01%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
1 task
mrstork
force-pushed
the
chore/upgrade-to-blobs-v8
branch
from
3272a0b
to
f07d8ec
Compare
mrstork
commented
Sep 18, 2024
| fetch: fetchBeforeNextPatchedIt, | ||
| experimentalRegion: | ||
| process.env.USE_REGIONAL_BLOBS?.toUpperCase() === 'TRUE' ? 'context' : undefined, | ||
| region: process.env.USE_REGIONAL_BLOBS?.toUpperCase() === 'TRUE' ? undefined : 'us-east-2', |
There was a problem hiding this comment.
context is now the default, us-east-2 is the old default
mrstork
commented
Sep 18, 2024
| @@ -153,10 +153,6 @@ export class PluginContext { | |||
| } | |||
|
|
|||
| get useRegionalBlobs(): boolean { | |||
| if (!(this.featureFlags || {})['next-runtime-regional-blobs']) { | |||
| return false | |||
| } | |||
There was a problem hiding this comment.
flag has been fully rolled out
mrstork
commented
Sep 18, 2024
|
|
||
| const fetchBeforeNextPatchedIt = globalThis.fetch | ||
|
|
||
| export const getRegionalBlobStore = (args: Parameters<typeof getDeployStore>[0] = {}): Store => { | ||
| const options = typeof args === 'string' ? { name: args } : args | ||
| export const getRegionalBlobStore = (args: GetWithMetadataOptions = {}): Store => { |
There was a problem hiding this comment.
Found a nice type to use for this 👍
pieh
reviewed
Sep 19, 2024
mrstork
force-pushed
the
chore/upgrade-to-blobs-v8
branch
from
179aaa4
to
7307012
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade to latest version of the blobs package and fixed up package references.
experimentalRegion: contextis now the default option for edge deploys and it was removed from the interface.Documentation
Blobs v8 upgrade:
netlify/blobs#183
Link to feature flag:
https://app.devcycle.com/o/org_dhCAK5hN1u5tXdf9/p/shared/features/6644def9bfcb11f2def7d11a
Replaces:
#2528
Tests
cli-before-regional-blobs-supportis failing, but it may be possible to remove this test now due to the new defaults