-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add description
field
#176
Conversation
Deploy preview for open-api ready! Built with commit 0606b4e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested some copy changes to account for copy-pasting from another location.
swagger.yml
Outdated
|
||
|
||
This document describes common usage in some detail. There is also an | ||
OpenAPI reference for the Netlify API that you can explore. Visit our |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "OpenAPI reference" mentioned here is this very page! I would reverse those two descriptions. In other words, explain that this site is a reference, and for more detailed instructions for common uses, visit netlify.com/docs/api.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in f126c12
swagger.yml
Outdated
|
||
This document describes common usage in some detail. There is also an | ||
OpenAPI reference for the Netlify API that you can explore. Visit our | ||
Community forum to join the conversation about understanding and using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also add back the community link that's in that intro at netlify.com/docs/api.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in a5ad674
cbab012
to
741fb4c
Compare
Thanks for the review @DavidWells and @verythorough! Note that Swagger UI does not seem to understand Markdown in description (although that's valid OpenAPI), so it's shown as one big link with no formatting. However the new UI based ReDoc (#182) should fix that. |
29dcbf3
to
fd10aae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This adds a
description
field which shows up on top the documentation explaining what Netlify API does.