Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description field #176

Merged
merged 4 commits into from
Sep 18, 2019
Merged

Add description field #176

merged 4 commits into from
Sep 18, 2019

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Sep 9, 2019

This adds a description field which shows up on top the documentation explaining what Netlify API does.

@netlify
Copy link

netlify bot commented Sep 9, 2019

Deploy preview for open-api ready!

Built with commit 0606b4e

https://deploy-preview-176--open-api.netlify.com

Copy link
Contributor

@verythorough verythorough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested some copy changes to account for copy-pasting from another location.

swagger.yml Outdated


This document describes common usage in some detail. There is also an
OpenAPI reference for the Netlify API that you can explore. Visit our
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "OpenAPI reference" mentioned here is this very page! I would reverse those two descriptions. In other words, explain that this site is a reference, and for more detailed instructions for common uses, visit netlify.com/docs/api.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in f126c12

swagger.yml Outdated

This document describes common usage in some detail. There is also an
OpenAPI reference for the Netlify API that you can explore. Visit our
Community forum to join the conversation about understanding and using
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also add back the community link that's in that intro at netlify.com/docs/api.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in a5ad674

@ehmicky ehmicky force-pushed the doc/add-description branch from cbab012 to 741fb4c Compare September 18, 2019 10:05
@ehmicky
Copy link
Contributor Author

ehmicky commented Sep 18, 2019

Thanks for the review @DavidWells and @verythorough!
I fixed the description, ready for another round of review @verythorough.

Note that Swagger UI does not seem to understand Markdown in description (although that's valid OpenAPI), so it's shown as one big link with no formatting. However the new UI based ReDoc (#182) should fix that.

@ehmicky ehmicky force-pushed the doc/add-description branch from 29dcbf3 to fd10aae Compare September 18, 2019 10:50
Copy link
Contributor

@verythorough verythorough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ehmicky ehmicky merged commit 9ac26e5 into master Sep 18, 2019
@ehmicky ehmicky deleted the doc/add-description branch September 18, 2019 14:35
@ehmicky
Copy link
Contributor Author

ehmicky commented Sep 18, 2019

Since it does not work with Swagger UI, I reverted this commit on master (6c7bcbb) but it's added back by #182.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants