build: migrate bundle pipeline to tsdown

[TheAlexLichter]

As tsup is not actively maintained anymore and there are faster tools as drop-in replacement available (based on Rolldown), I took a few minutes to migrate the packages over to tsdown.

This should yield in faster builds (bundling and speedy DTS generation).

PS: Sorry for the drive-by PR!

[TheAlexLichter]

Issues are fixed & tests run locally as expected 👍🏻 (cc @serhalp)

[serhalp]

sorry for the delays on this one @TheAlexLichter. If you can give this one more update we'll get it merged! Thanks for the PR! 😄

[TheAlexLichter]

@serhalp No worries! Updated, build + tests passing locally. (Lint errors are from main)

[serhalp]

@TheAlexLichter hmm, those tests are failing on all platforms and I can repro locally on your branch. how are you running tests locally?

build first:

npm run --workspaces build

run all tests:

npm run --workspaces test:ci

(or test:dev)

run tests for one package (e.g. packages/vite-plugin and packages/otel are failing):

npm run -w ./packages/vite-plugin test:ci

seems to be something with a transitive dependency of packages/otel missing... could it be a tsdown/rolldown bug? misconfiguration on our part?

[serhalp]

hmm @TheAlexLichter:

tsdown requires Node.js version 20.19 or higher. Please ensure your development environment meets this requirement before installing. While tsdown is primarily tested with Node.js, support for Deno and Bun is experimental and may not work as expected.

from https://tsdown.dev/guide/getting-started

these packages mostly support and test >=20.6.1 (some even ^18.14.0 || >=20 and one ^14.16.0 || >=16.0.0). that might be related? (although CI is failing on 22.x)

is this PR even viable, given this?

[serhalp]

maybe related to rolldown/tsdown#317 ? @TheAlexLichter

[TheAlexLichter]

Should be fine as consumers import via the entry points only 👍🏻

[chee]

we turned off splitting because of a packaging issue in deno 2 that we should probably investigate if we're changing that

[TheAlexLichter]

Okay, let's ensure that this packaging issue is resolved by now (or we can adapt the config to avoid code splitting with a workaround)

[TheAlexLichter]

Strange! Tests all pass fine (I built & ran with node v24.2.0 though).

I just updated the lockfile, seems that was faulty in between (I guess some merge conflicts earlier).

tsdown requires Node.js version 20.19 or higher. Please ensure your development environment meets this requirement before installing. While tsdown is primarily tested with Node.js, support for Deno and Bun is experimental and may not work as expected.

these packages mostly support and test >=20.6.1 (some even ^18.14.0 || >=20 and one ^14.16.0 || >=16.0.0). that might be related? (although CI is failing on 22.x)

is this PR even viable, given this?

This is only for the actual CI server / dev environment. The actual target of the libs can be as low as the transformer supports.

[chee]

This is only for the actual CI server / dev environment. The actual target of the libs can be as low as the transformer supports.

when we test on node 18, we build on node 18:

https://github.com/netlify/primitives/blob/main/.github/workflows/test.yaml#L56-L90

(we don't have to do that, but we do that at the moment)

[TheAlexLichter]

This is only for the actual CI server / dev environment. The actual target of the libs can be as low as the transformer supports.

when we test on node 18, we build on node 18:

main/.github/workflows/test.yaml#L56-L90

(we don't have to do that, but we do that at the moment)

Checked locally and building + testing works fine with Node 18 too 👍🏻

CI is also green in my fork