fix: parse minified boolean (#1665)

largeDepsEsbuild: 1.5s
largeDepsNft: 5.6s
largeDepsZisi: 10.5s
netlify · Nov 22, 2023 · 8ac5b33 · 8ac5b33 · github-actions · Nov 22, 2023
1 parent 145bc5f
commit 8ac5b33
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/src/runtimes/node/parser/exports.ts b/src/runtimes/node/parser/exports.ts
@@ -245,6 +245,12 @@ const parsePrimitive = (exp: Expression | PatternLike): PrimitiveResult => {
   if (exp.type === 'NullLiteral') {
     return null
   }
+
+  // special case: minifiers like to transform `true` to `!0` and `false` to `!1`.
+  // because this can be hard to turn off for some frameworks, we have a special case.
+  if (exp.type === 'UnaryExpression' && exp.operator === '!' && exp.argument.type === 'NumericLiteral') {
+    return !exp.argument.value
+  }
 }
 
 /**

diff --git a/tests/unit/runtimes/node/in_source_config.test.ts b/tests/unit/runtimes/node/in_source_config.test.ts
@@ -692,5 +692,20 @@ describe('V2 API', () => {
 
       expect(routes).toEqual([{ pattern: '/products', literal: '/products', methods: [] }])
     })
+
+    test('Understands minfied true', () => {
+      const source = `export default async () => {
+        return new Response("Hello!")
+      }
+  
+      export const config = {
+        path: "/products",
+        preferStatic: !0
+      }`
+
+      const { routes } = parseSource(source, options)
+
+      expect(routes).toEqual([{ pattern: '/products', literal: '/products', methods: [], prefer_static: true }])
+    })
   })
 })