This repository has been archived by the owner on May 22, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱ Benchmark resultsComparing with b06d5a2 largeDepsEsbuild: 1.3s⬇️ 2.28% decrease vs. b06d5a2
Legend
largeDepsNft: 5.5s⬇️ 0.28% decrease vs. b06d5a2
Legend
largeDepsZisi: 10.3s⬇️ 1.17% decrease vs. b06d5a2
Legend
|
biruwon
approved these changes
Apr 1, 2024
JGAntunes
approved these changes
Apr 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I approve this test deletion!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We have an integration test in this repository that clones the latest version of the Next.js runtime and builds the demo site. This means that any change in the Next.js runtime repo may cause the test to fail without a clear indication as to why and without no clear path to resolution from the PR author.
This PR removes that test, which we should replace with the more comprehensive end-to-end test suite we're working on.