This repository has been archived by the owner on May 22, 2024. It is now read-only.
feat: add nativeNodeModules
property to output
#433
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
This PR adds a
nativeNodeModules
property to the return value ofzipFunction
andzipFunctions
with any native modules detected as part of the logic added in #418. This object has the following shape:With this property, we'll be able to show warnings in the CLI whenever the user is about to locally build and deploy a function with native modules.
Note that this currently only works when building with esbuild. Given that we're making it the new default in less than a month, I'm not sure the effort of adding this detection to the legacy bundler is worth the trouble, but I'm happy to discuss this.
- Test plan
Adjusted existing tests.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)