Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

fix: use BINARY_PATH constant in tests #979

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Jan 28, 2022

Part of #749

This uses a shared variable for the path to the main binary in tests.

That path needs to be reworked for pure ES modules, so this helps the migration.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code
    🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re
    fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

@ehmicky ehmicky added the type: chore work needed to keep the product and development running smoothly label Jan 28, 2022
@github-actions github-actions bot added the type: bug code to address defects in shipped code label Jan 28, 2022
@ehmicky ehmicky removed the type: bug code to address defects in shipped code label Jan 28, 2022
@ehmicky ehmicky mentioned this pull request Jan 28, 2022
@erezrokah erezrokah enabled auto-merge (squash) February 8, 2022 12:57
@erezrokah erezrokah merged commit fe96bc0 into main Feb 8, 2022
@erezrokah erezrokah deleted the chore/binary-path-tests branch February 8, 2022 13:08
Skn0tt pushed a commit to netlify/build that referenced this pull request May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants