Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove getty and udev targets to lower CPU usage #27

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

sblaisot
Copy link
Contributor

@sblaisot sblaisot commented Mar 1, 2020

Remove systemd's getty and udev targets to lower CPU usage when using containers

@myii
Copy link
Collaborator

myii commented Mar 11, 2020

@sblaisot I like the idea behind this because I've suffered from this previously. I'm finding I'm short on time to test this at the moment, though. I reckon we could go ahead and merge it, since it seems fine from an eyeball review. What do you think, @javierbertoli?

@javierbertoli
Copy link
Member

Agreed. I left it opened to extend the idea to the other distros too, but I'm short of time too.

@sblaisot would you dare extend it to the other distros too? After all, if something breaks, we can find out with the tests and revert.

If you prefer not to do it, we might just add a ticket to remember doing it in the future.

@myii myii merged commit 1a424fb into netmanagers:master Mar 11, 2020
@myii
Copy link
Collaborator

myii commented Mar 11, 2020

Merging this now so that #29 can be merged cleanly, which is further going to be extended with the OpenSUSE workaround. I'll make an issue for getty on the other platforms.

myii added a commit to noelmcloughlin/packages-formula that referenced this pull request Mar 27, 2020
myii added a commit to myii/systemd-formula that referenced this pull request Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants