[REF] Labels <0 are set to 0 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Who uses negative labels anyways?
github-actions bot
pushed a commit
that referenced
this pull request
Jun 29, 2021
[REF] Labels <0 are set to 0 e6f678c
github-actions bot
pushed a commit
to rmarkello/neuromaps
that referenced
this pull request
Jun 29, 2021
[REF] Labels <0 are set to 0 e6f678c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will only impact usage of
images.annot_to_gifti()andimages.relabel_gifti(), wherein users providing annotation and/or gifti files that have negative labels will find those labels are automatically set to the background value (0). Because, honestly, who uses negative labels? 🧐Will try and create tests for the impacted functions (since none exist right now!).