Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to go1.23 #780

Merged
merged 1 commit into from
Dec 20, 2024
Merged

move to go1.23 #780

merged 1 commit into from
Dec 20, 2024

Conversation

jotak
Copy link
Member

@jotak jotak commented Dec 17, 2024

No description provided.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.14%. Comparing base (1a35a9a) to head (37bba3c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #780   +/-   ##
=======================================
  Coverage   65.14%   65.14%           
=======================================
  Files         112      112           
  Lines        8539     8539           
=======================================
  Hits         5563     5563           
  Misses       2654     2654           
  Partials      322      322           
Flag Coverage Δ
unittests 65.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jotak
Copy link
Member Author

jotak commented Dec 17, 2024

/retest

@jotak
Copy link
Member Author

jotak commented Dec 20, 2024

/approve

@jotak
Copy link
Member Author

jotak commented Dec 20, 2024

/lgtm
/approve

Copy link

openshift-ci bot commented Dec 20, 2024

@jotak: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Dec 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak jotak merged commit 92cf79c into netobserv:main Dec 20, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants