Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-200: Basic flows' agent architecture #2

Merged
merged 2 commits into from
Mar 14, 2022
Merged

NETOBSERV-200: Basic flows' agent architecture #2

merged 2 commits into from
Mar 14, 2022

Conversation

mariomac
Copy link

It provides a basic agent architecture that fetches very basic flow
information and prints it in standard output.

This PR does not want to provide complete Flow's information. It
will be done in a later PR.

@mariomac mariomac changed the title NETOBSERV-2000: Basic flows' agent architecture NETOBSERV-200: Basic flows' agent architecture Mar 11, 2022
Mario Macias added 2 commits March 11, 2022 14:28
It provides a basic agent architecture that fetches very basic flow
information and prints it in standard output.

This PR does not want to provide complete Flow's information. It
will be done in a later PR
Copy link
Contributor

@OlivierCazade OlivierCazade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Side question not related to this PR, is there a particular reason to track bpf object files?

@mariomac
Copy link
Author

@OlivierCazade I usually prefer to put generated files into a generated folder structure (like we usually do in Java) and exclude it from Git. However, the functions generated inside the bpf_bpfe* files are private and must be in the same folder as the tracer.go file from us.

If you prefer, we can anyway include these files individually in the .gitignore.

@mariomac mariomac merged commit 4978ea5 into netobserv:main Mar 14, 2022
@mariomac mariomac deleted the basic branch March 14, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants