Fix OSGi import package version for net.minidev.asm.

[msqr]

I am trying to deploy json-smart in an OSGi runtime, and found that it imports the net.minidev.asm package with a version range of [2.5,3), taken from this snippet of MANIFEST.MF:

Import-Package: net.minidev.asm;version="[2.5,3)",net.minidev.json,net
 .minidev.json.annotate,net.minidev.json.parser,net.minidev.json.reade
 r,net.minidev.json.writer

However the net.minidev:asm JAR is up to version 1.0.2. I was able to load both json-smart and the asm bundles in my OSGi runtime by tweaking the import package configuration in the POM, to explicitly define the import version of net.minidev.asm as 1.0. That produces the following MANIFEST.MF result:

Import-Package: net.minidev.asm;version="1.0",net.minidev.json,net.minid
 ev.json.annotate,net.minidev.json.parser,net.minidev.json.reader,net.mi
 nidev.json.writer

[hezhangjian]

Hi, @msqr Thanks for your contribution. But I think it will be better to specify the dependencies instead of using *
I am not OSGI experts, tell me if I was wrong.

[msqr]

I believe using a wildcard * clause is fairly common with bnd (the default when no <Import-Package> is provided is in fact *) as bnd already figures out what imports are needed and this ends up requiring less maintenance over time. In this case the only package not provided by this JAR itself is the net.minidev.asm one, which requires an explicit version range to match the exports in the asm JAR.

Another approach would be to limit the wildcard to the specific packages, like

<Import-Package>
	net.minidev.asm;version="1.0",
	net.minidev.json.*
</Import-Package>

That produces this MANIFEST.MF entry:

Import-Package: net.minidev.asm;version="1.0",net.minidev.json;version="
 [2.5,3)",net.minidev.json.annotate;version="[2.5,3)",net.minidev.json.p
 arser;version="[2.5,3)",net.minidev.json.reader;version="[2.5,3)",net.m
 inidev.json.writer;version="[2.5,3)"

That is a bit more explicit with the package version ranges, but that is not normally how I see OSGi bundles produced: bundles import the packages they themselves export, but without a version range.

[hezhangjian]

@msqr Thanks for your explanation.

[hezhangjian]

@msqr tell me if your want a new release.

[msqr]

A new release would be very helpful, yes. Thanks!

[croister]

I do not believe this change to be correct.
We should not use the old 1.x net.minidev:asm bundle.
The net.minidev:asm bundle was re-named to net.minidev:accessors-smart back in 2015, see: dd76b1c
You should use the net.minidev:accessors-smart 2.5.1 bundle (and the org.objectweb:asm bundle that it depends on) instead.

[msqr]

Thanks @croister I hadn't noticed that artifact name change. Indeed accessors-smart:2.5.1 exports the net.minidev.asm package with version 2.5.1, so that should work, without this change.

[croister]

I suggest that the commit is reverted and a new release is made.