Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Encoding Firebase push notification keys #187

Merged
merged 27 commits into from
Dec 25, 2024
Merged

fix: Encoding Firebase push notification keys #187

merged 27 commits into from
Dec 25, 2024

Conversation

cbaker6
Copy link
Member

@cbaker6 cbaker6 commented Oct 25, 2024

New Pull Request Checklist

Issue Description

Approach

  • Firebase encoding keys should use underscores instead of dashes
  • Bump to latest Xcode
  • Only build linux for latest 5.x as 6.x forces Swift 6 conversion

TODOs before merging

  • Add tests
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.82%. Comparing base (4799684) to head (1bd7322).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
+ Coverage   91.65%   91.82%   +0.16%     
==========================================
  Files         179      179              
  Lines       15874    15919      +45     
==========================================
+ Hits        14550    14617      +67     
+ Misses       1324     1302      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbaker6 cbaker6 changed the title fix: Build for Swift 6.0.1 on Linux ci: Build for the latest version of Xcode Dec 25, 2024
@cbaker6 cbaker6 changed the title ci: Build for the latest version of Xcode fix: Encoding Firebase push notification keys Dec 25, 2024
@cbaker6 cbaker6 merged commit 0d51e70 into main Dec 25, 2024
14 checks passed
@cbaker6 cbaker6 deleted the cbaker6-patch-1 branch December 25, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant