Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline mode #40

Closed
wants to merge 77 commits into from
Closed

Offline mode #40

wants to merge 77 commits into from

Conversation

vdkdamian
Copy link

New Pull Request Checklist

Issue Description

This adds the possibility to use ParseSwift with offline mode. Objects will be stored on device if needed and can be fetched when internet connection is back.

Closes: #39

Approach

I will add playground examples on how to use it.

TODOs before merging

  • Test
  • Linting
  • Add tests
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • Add playground examples

@vdkdamian
Copy link
Author

First 4 commits are not correct, don't know how to get em out

@vdkdamian
Copy link
Author

I think I need to change the moment om saving the objects locally.
I would need to save to result from a saveCommand in order to get the correct updatedAt date.

@cbaker6 What do you think about this approach?

@cbaker6
Copy link
Member

cbaker6 commented Jan 2, 2023

You will need to resolve the merge conflicts and design the local storage following what I mentioned here, https://github.com/parse-community/Parse-Swift/projects/2#card-53117524 to be considered for this repo.

You also didn't fork from this repo, so this PR won't work as is.

@cbaker6 cbaker6 marked this pull request as draft January 2, 2023 03:14
@vdkdamian
Copy link
Author

You will need to resolve the merge conflicts and design the local storage following what I mentioned here, https://github.com/parse-community/Parse-Swift/projects/2#card-53117524 to be considered for this repo.

Do you think there is something usefull in my code? I looked at the project you mentioned. Seems like a total different approach. Still would look forward if I can help.
I'm learning a lot from you so any help would be appreciated 🙂

You also didn't fork from this repo, so this PR won't work as is.
I'll fix this as soon as possible!

@cbaker6
Copy link
Member

cbaker6 commented Jan 2, 2023

From your posts, you have designed this for the parse-community Parse-Swift with the intent of getting it accepted there. I recommend you reach out to them and ask for a code review. I will not review code that’s intended for that repo.

@vdkdamian vdkdamian closed this Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add offline object saving
3 participants