Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Switch LiveQuery listen to watch #48

Merged
merged 1 commit into from
Jan 18, 2023
Merged

fix: Switch LiveQuery listen to watch #48

merged 1 commit into from
Jan 18, 2023

Conversation

cbaker6
Copy link
Member

@cbaker6 cbaker6 commented Jan 16, 2023

New Pull Request Checklist

Issue Description

Add support for parse-community/parse-server#8028

Approach

TODOs before merging

  • Ensure tests pass

@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Merging #48 (42d1f89) into main (8da4178) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
- Coverage   90.34%   90.34%   -0.01%     
==========================================
  Files         163      163              
  Lines       16361    16361              
==========================================
- Hits        14782    14781       -1     
- Misses       1579     1580       +1     
Impacted Files Coverage Δ
Sources/ParseSwift/LiveQuery/Messages.swift 100.00% <100.00%> (ø)
Sources/ParseSwift/Types/Query.swift 88.56% <100.00%> (ø)
Sources/ParseSwift/Objects/ParseObject+async.swift 96.29% <0.00%> (-0.38%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cbaker6 cbaker6 merged commit 1e2d713 into main Jan 18, 2023
@cbaker6 cbaker6 deleted the listenToWatch branch January 18, 2023 00:41
@dblythy
Copy link

dblythy commented Jan 20, 2023

You're very quick with it! Not sure if you noticed too, but it seems I made an oversight in the addition of the feature and it'll only work on client side once parse-community/parse-server#8388 is merged.

@cbaker6
Copy link
Member Author

cbaker6 commented Jan 20, 2023

Not sure if you noticed too, but it seems I made an oversight in the addition of the feature and it'll only work on client side

Thanks! I haven't tested this on the server yet, but it should send everything needed from the Swift SDK. The design of the Swift SDK Query and LiveQuery makes it straight-forward to add new features (typically). The tests are usually harder to write than the feature itself.

I'll keep an eye on your PR and test it once it's merged. I also added your Health updates as well in #43. Let me know if there's a feature I missed in 6.0.0. Of course, if you want to add it, you are more than welcome to open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants