Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

Add label options to shipment request #11

Closed

Conversation

JustoHermano
Copy link

@JustoHermano JustoHermano commented Sep 3, 2020

My company had a need to always request a waybill document so I added the label options object so we could always request this.

Please let me know if there are any changes that need to be made to be more in line with this library.

@mam08ixo
Copy link
Contributor

mam08ixo commented Sep 7, 2020

Thank you for your contribution!

I made some adjustments in branch pr-11. The main change is the request builder method being named more clearly now (ShipmentRequestBuilderInterface::setWaybillDocumentRequested). Please check if everything works for you as expected. If so, I am happy to merge the feature.

@JustoHermano
Copy link
Author

@mam08ixo Looks great!!

@mam08ixo mam08ixo closed this in eaf958c Sep 8, 2020
@JustoHermano
Copy link
Author

@mam08ixo Can you create a tagged release so we can use the new functionality?

@Sebastian80
Copy link
Contributor

Hi @JustoHermano ,

new version is tagged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants