Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update module github.com/gofiber/fiber/v2 to v2.49.2 [security] #16

Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 14, 2023

Mend Renovate

This PR contains the following updates:

Package Type Update Change
github.com/gofiber/fiber/v2 require minor v2.48.0 -> v2.49.2

GitHub Vulnerability Alerts

CVE-2023-41338

Impact

This vulnerability can be categorized as a security misconfiguration. It impacts users of our project who rely on the ctx.IsFromLocal() method to restrict access to localhost requests. If exploited, it could allow unauthorized access to resources intended only for localhost.

In it's implementation it uses c.IPs():

// IPs returns a string slice of IP addresses specified in the X-Forwarded-For request header.
// When IP validation is enabled, only valid IPs are returned.
func (c *Ctx) IPs() []string {
    return c.extractIPsFromHeader(HeaderXForwardedFor)
}

Thereby, setting X-Forwarded-For: 127.0.0.1 in a request from a foreign host, will result in true for ctx.IsFromLocal()

Patches

This issue has been patched in v2.49.2 with commit b8c9ede6efa231116c4bd8bb9d5e03eac1cb76dc

Workarounds

Currently, there are no known workarounds to remediate this vulnerability without upgrading to the patched version. We strongly advise users to apply the patch as soon as it is released.

References

For further information and context regarding this security issue, please refer to the following resources:


Release Notes

gofiber/fiber (github.com/gofiber/fiber/v2)

v2.49.2

Compare Source

🧹 Updates

  • Middleware/logger: Enabling color changes padding for some fields #​2604 (#​2616)
  • Bump actions/checkout from 3 to 4 (#​2618)
  • Bump golang.org/x/sys from 0.11.0 to 0.12.0 (#​2617)

🐛 Fixes

  • Vulnerability in Ctx.IsFromLocal()

📚 Documentation

  • Replaced double quotes with backticks in all route parameter strings (#​2591)

Full Changelog: gofiber/fiber@v2.49.1...v2.49.2

Thank you @​11-aryan and @​AKARSHITJOSHI for making this update possible.

v2.49.1

Compare Source

🧹 Updates

  • Bump github.com/valyala/fasthttp from 1.48.0 to 1.49.0 (#​2615)

🐛 Fixes

  • Rollback changes to go.mod file (#​2614)

📚 Documentation

  • Add Polish translation - README_pl.md (#​2613)
  • Update README_ko.md (#​2605)

Full Changelog: gofiber/fiber@v2.49.0...v2.49.1

Thank you @​KompocikDot, @​LimJiAn and @​gaby for making this update possible.

v2.49.0

Compare Source

❗ Breaking Changes

EnableSplittingOnParsers splits the query/body/header parameters by comma when it's true (default: false).

For example, you can use it to parse multiple values from a query parameter like this:
/api?foo=bar,baz == foo[]=bar&foo[]=baz

🚀 New

This allows the user to use //go:embed flags to load favicon data during build-time, and supply it to the middleware instead of reading the file every time the application starts.

🧹 Updates

  • Middleware/logger: Latency match gin-gonic/gin formatter (#​2569)
  • Middleware/filesystem: Refactor: use errors.Is instead of os.IsNotExist (#​2558)
  • Use Global vars instead of local vars for isLocalHost (#​2595)
  • Remove redundant nil check (#​2584)
  • Bump github.com/mattn/go-runewidth from 0.0.14 to 0.0.15 (#​2551)
  • Bump github.com/google/uuid from 1.3.0 to 1.3.1 (#​2592)
  • Bump golang.org/x/sys from 0.10.0 to 0.11.0 (#​2563)
  • Add go 1.21 to ci and readmes (#​2588)

🐛 Fixes

  • Middleware/logger: Default latency output format (#​2580)
  • Decompress request body when multi Content-Encoding sent on request headers (#​2555)

📚 Documentation

  • Fix wrong JSON docs (#​2554)
  • Update io/ioutil package to io package (#​2589)
  • Replace EG flag with the proper and smaller SVG (#​2585)
  • Added Egyptian Arabic readme file (#​2565)
  • Translate README to Portuguese (#​2567)
  • Improve *fiber.Client section (#​2553)
  • Improved the config section of the middleware readme´s (#​2552)
  • Added documentation about ctx Fresh (#​2549)
  • Update intro.md (#​2550)
  • Fixed link to slim template engine (#​2547)

Full Changelog: gofiber/fiber@v2.48.0...v2.49.0

Thank you @​Jictyvoo, @​Juneezee, @​Kirari04, @​LimJiAn, @​PassTheMayo, @​andersonmiranda-com, @​bigpreshy, @​efectn, @​renanbastos93, @​scandar, @​sixcolors and @​stefanb for making this update possible.


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/go-github.com/gofiber/fiber/v2-vulnerability branch from d85f597 to 09c6439 Compare September 15, 2023 23:13
@TheDevMinerTV TheDevMinerTV merged commit bb86b4e into master Sep 15, 2023
2 checks passed
@renovate renovate bot deleted the renovate/go-github.com/gofiber/fiber/v2-vulnerability branch September 15, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant