Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first select-image-rendering #38

Closed
prdt3e opened this issue Nov 30, 2018 · 3 comments
Closed

first select-image-rendering #38

prdt3e opened this issue Nov 30, 2018 · 3 comments

Comments

@prdt3e
Copy link
Contributor

prdt3e commented Nov 30, 2018

There is a little bit of a logic error (in the JS) anyway
Currently it like this:

  1. Select picture
  2. Rendering
  3. Dialog
  4. Insert original image

the order should be like this:

  1. Select picture
  2. Get picture info (FileObject) (Ajax / SelectImageController.php ->getinfos)
  3. Dialog with width, title, description
  4. "again" ajax with rendering (Ajax / SelectImageController.php -> processImage) would then return the generated image.

As it is now, the original image is inserted the first time, only after saving the proccessed file appears.
@prdt3e prdt3e changed the title first select-iamge-rendering first select-image-rendering Nov 30, 2018
muh-nr pushed a commit that referenced this issue Jun 28, 2019
@mcmulman
[REFACTOR] #38: Process image on first selection
3a8d388
muh-nr pushed a commit that referenced this issue Jun 28, 2019
@mcmulman
[REFACTOR] #38: Process image on first selection
f58cd6c
muh-nr pushed a commit that referenced this issue Jun 28, 2019
@mcmulman
[REFACTOR] #38: Process image on first selection
0ceedea
@muh-nr
Copy link
Contributor

muh-nr commented Jun 28, 2019 •
edited
Loading

@prdt3e

Fixed it in #55.
Please have a try.

muh-nr added a commit that referenced this issue Jul 3, 2019
@muh-nr
[REFACTOR] #38: Process image on first selection (#55)
c0a4474
@muh-nr
Copy link
Contributor

muh-nr commented Jul 3, 2019

Merged into master!

@muh-nr muh-nr closed this as completed Jul 3, 2019
@prdt3e
Copy link
Contributor Author

prdt3e commented Jul 3, 2019

i like :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@muh-nr @prdt3e